Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove mentions of exports wildcard limitations #9827

Closed
wants to merge 1 commit into from

Conversation

baptisteArno
Copy link

This PR removes all the mentions of exports wildcard limitations as it is not the case anymore microsoft/TypeScript#54831

Here is also a screen recording that proves it:

CleanShot.2025-01-25.at.10.41.27.mp4

@baptisteArno baptisteArno requested review from anthonyshew and a team as code owners January 28, 2025 08:23
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage labels Jan 28, 2025
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 8:23am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 8:23am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 8:23am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 8:23am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 8:23am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 8:23am

Copy link

vercel bot commented Jan 28, 2025

@baptisteArno is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@anthonyshew
Copy link
Contributor

From what I understand from the TypeScript team in the past, the amount of imports it suggests stops at 10. Are you able to test that? Would love if this behavior changed and I didn't hear about it. 😄

@baptisteArno
Copy link
Author

From what I understand from the TypeScript team in the past, the amount of imports it suggests stops at 10. Are you able to test that? Would love if this behavior changed and I didn't hear about it. 😄

What do you mean by that exactly? Does that mean the suggest menu would offer max 10 options (which I find enough) or something else?

@anthonyshew
Copy link
Contributor

It only works for up to 10 exports subpaths for the package due to performance concerns, is what I was told. That was a while back, though, so that could've changed (like in the PR you've linked).

@anthonyshew anthonyshew removed the request for review from chris-olszewski January 30, 2025 16:04
@anthonyshew
Copy link
Contributor

@baptisteArno Did you get a chance to peek at this yet? I'm seeing the behavior as consistent with my past learnings on this topic, but happy to change if you're seeing something different.

@anthonyshew
Copy link
Contributor

anthonyshew commented Feb 16, 2025

Going to close this in favor of #9983 since it has a bit more coverage, but I made mention that you should get credit in the description! If you'd like, I can also hand-edit the release notes anywhere that #9983 shows up so that they have your name on them instead of me. Let me know if you'd like me to do that!

@baptisteArno
Copy link
Author

No worries @anthonyshew! Sorry I was super busy 🙏

No need for credits 😄

anthonyshew added a commit that referenced this pull request Feb 18, 2025
### Description

@thdxr kindly pointed out that the wildcard recommendations in our docs
weren't matching what he was seeing in his editor. I investigated and am
similarly seeing that wildcard recommendations work as one would hope.
The last time that I tried this, there was some limit at 10 exports
paths or 10 variable exports (my memory is fuzzy). But that appears to
be removed now in latest versions of TypeScript with modern settings
(which is what the Turborepo docs on other tools always assume).

Additional credit to @baptisteArno who also was pointing this out to me
in #9827. I'm going to use this PR since it has a few more spots in docs
where things are updated, and has additional updates to our examples.
But let the record show that @baptisteArno deserves credits here!

### Testing

I hand-tested this in my editor and here's what I see. One or more of
these didn't used to work but now it does.

![CleanShot 2025-02-15 at 23 32
38@2x](https://github.com/user-attachments/assets/ac7a44b3-8fe3-4a72-a580-2abb151d2100)

Additionally, here is my editor recommending 10+ entrypoints.
![CleanShot 2025-02-15 at 23 35
19@2x](https://github.com/user-attachments/assets/695087e4-5e29-474a-b573-cadd62e14fab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants